Check Too: Update validation messages #777
Conversation
WalkthroughThe pull request focuses on updating validation messages in the Changes
Assessment against linked issues
Possibly related PRs
Suggested reviewers
Poem
Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
src/filters/validationMessageLookup.js (2)
25-25: Consider using British English spelling for 'recognised'.The validation message is clear and actionable. However, to maintain consistency with British English, consider changing "recognized" to "recognised".
- mimeTypeMalformed: 'The selected file has a malformed mime type and is not recognised. Try creating a new version and uploading again, or contact your server administrator for support' + mimeTypeMalformed: 'The selected file has a malformed mime type and is not recognised. Try creating a new version and uploading again, or contact your server administrator for support'
50-50: Consider standardising URL format messages across fields.While the message is clear, notice that the documentation-url field uses a different format message style. Consider standardising the format messages across all URL fields for consistency.
- format: 'Enter a valid documentation URL', + format: 'Documentation URL must start with http:// or https://, have no spaces or unusual characters like { } [ ]',
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
src/filters/validationMessageLookup.js(2 hunks)test/unit/dataset-details.test.js(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: run-tests / test
🔇 Additional comments (3)
src/filters/validationMessageLookup.js (2)
31-31: LGTM! Clear and well-formatted message.The message follows GOV.UK style guidelines and uses proper punctuation.
36-36: LGTM! Follows GOV.UK error message pattern.The message appropriately communicates the service error and provides a clear next step.
test/unit/dataset-details.test.js (1)
82-82: LGTM! Test correctly updated to match new validation message.The test expectation has been properly aligned with the updated validation message from validationMessageLookup.js.
What type of PR is this? (check all applicable)
Description
A few validation messages were updated. No changes in behaviour.
Related Tickets & Documents
Closes #712
QA Instructions, Screenshots, Recordings
Added/updated tests?
We encourage you to keep the code coverage percentage at 80% and above.
QA sign off
[optional] Are there any post-deployment tasks we need to perform?
[optional] Are there any dependencies on other PRs or Work?
Summary by CodeRabbit
Bug Fixes
Documentation